feat: remove page hide event from triggering unload event listener #31853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: remove page hide event from triggering unload event listener
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-pagehide-from-unload-listener
|
| Run status |
|
| Run duration | 19m 56s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
11
|
Pending
|
1097
|
Skipped
|
0
|
Passing
|
26525
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.86%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
157
|
Accessibility
92.89%
|
|
|---|---|
|
Failed rules
|
3 critical
9 serious
2 moderate
2 minor
|
|
Failed elements
|
671
|
cacieprins
approved these changes
Jun 11, 2025
|
@cacieprins We want to deprecate window:unload listener, but that didn't have to be in the breaking change release. Definitely not going to add the page:hide listener since this current listener is really rarely used already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: remove page hide event from triggering unload event listener
Additional details
This is removing emitting the
pagehideevent in thewindow:unloadlistener - this change is not intended to impact any internal listening of thepagehideevent for Cypress functionality.The deprecation of window:unload listener is a separate piece of work and not breaking outlined here: #29524
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?